-
Notifications
You must be signed in to change notification settings - Fork 110
Prepare for litd v0.16.0-alpha release
#1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ViktorT-11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on preparing Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares litd for the v0.16.0-alpha release by updating version numbers and release notes. The changes in version.go and README.md are correct and align with the new release version. In the release notes, I've pointed out that some specific RPC package versions for Loop and Taproot Assets have been omitted in the new format. While this might be an intentional simplification, it would be good to confirm this to ensure no important information is lost for developers.
| ## Daemon Versions packaged with LiT | ||
|
|
||
| | LiT | LND | Loop | Faraday | Pool | Taproot Assets | | ||
| |-----------------------|------------------|--------------|---------------|--------------|------------------| | ||
| | **v0.16.0-alpha.rc1** | v0.20.0-beta.rc2 | v0.31.5-beta | v0.2.16-alpha | v0.6.6-beta | v0.7.0-alpha.rc2 | | ||
| | **v0.15.3-alpha** | v0.19.3-beta | v0.31.5-beta | v0.2.16-alpha | v0.6.6-beta | v0.6.1-alpha | | ||
| | **v0.15.2-alpha** | v0.19.3-beta | v0.31.2-beta | v0.2.16-alpha | v0.6.6-beta | v0.6.1-alpha | | ||
| | **v0.15.1-alpha** | v0.19.2-beta | v0.31.2-beta | v0.2.16-alpha | v0.6.6-beta | v0.6.1-alpha | | ||
| | **v0.15.0-alpha** | v0.19.1-beta | v0.31.2-beta | v0.2.16-alpha | v0.6.6-beta | v0.6.0-alpha | | ||
| | **v0.14.1-alpha** | v0.18.5-beta | v0.29.0-beta | v0.2.14-alpha | v0.6.5-beta | v0.5.1-alpha | | ||
| | **v0.14.0-alpha** | v0.18.4-beta | v0.29.0-beta | v0.2.13-alpha | v0.6.5-beta | v0.5.0-alpha | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have this table in the README. This information is available in the GitHub release page for each lit release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. Should we leave this for now though, and discuss this with the overall team and potentially drop these in a separate PR? Just so that the release doesn't get stalled on that. Same applies for:
#1178 (comment)
| ## Compatibility | ||
|
|
||
| Full Lightning Terminal functionality can be dependent on running a compatible | ||
| version of `lnd`. View the table below to ensure that you run a compatible | ||
| version of `lnd` with the relevant `litd` release. | ||
|
|
||
| This version compatibility dependency table is only relevant when running litd | ||
| in remote mode (meaning that `lnd-mode=remote` is set). It shows the | ||
| **_minimum_** `lnd` version that can be used with different versions of `litd` | ||
| (LiT). The bundled version will always come with the correct, | ||
| [compatible versioning](#daemon-versions-packaged-with-lit). | ||
|
|
||
| | LiT | LND | | ||
| |-----------------------|--------------| | ||
| | **v0.16.0-alpha.rc1** | v0.19.0-beta | | ||
| | **v0.15.3-alpha** | v0.19.0-beta | | ||
| | **v0.15.2-alpha** | v0.19.0-beta | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO min LND version support should just be in the release notes on the GitHub release page. I think of this as release specific data and not really top level project README data. I think we should retire this table to ./docs and just add a note to the GitHub release page (and template).
b9ce50a to
ce5f617
Compare
|
Theme of my review is: why are we doing things like that 😄 Maybe we can avoid updating the README for each new release? |
ce5f617 to
36dbaa2
Compare
jamaljsr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK LGTM 👌
Tested the litd and Terminal UIs against this. Also ran the Terminal e2e tests with no issues.
|
Thanks a lot for the review @jamaljsr 🎉! Sorry, I managed to miss-click on re-request review, so please just ACK again if possible :). |
ffranr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can take another look at rm-ing README lines another time 👍
This PR prepares
litdfor thev0.16.0-alpharelease.